Skip to content

manual 4.14 rebase to catch up - #2003

Closed
dhellmann wants to merge 9 commits into
openshift:mainfrom
dhellmann:rebase-4.14.0-0.nightly-2023-07-05-191022_amd64-2023-07-05_arm64-2023-07-05
Closed

manual 4.14 rebase to catch up#2003
dhellmann wants to merge 9 commits into
openshift:mainfrom
dhellmann:rebase-4.14.0-0.nightly-2023-07-05-191022_amd64-2023-07-05_arm64-2023-07-05

Conversation

@dhellmann

Copy link
Copy Markdown
Contributor

./scripts/auto-rebase/rebase.sh to "registry.ci.openshift.org/ocp/release:4.14.0-0.nightly-2023-07-05-191022" "registry.ci.openshift.org/ocp-arm64/release-arm64:4.14.0-0.nightly-arm64-2023-07-05-221234" "registry.access.redhat.com/lvms4/lvms-operator-bundle:v4.12"

@dhellmann dhellmann added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 6, 2023
@dhellmann

Copy link
Copy Markdown
Contributor Author

/assign @chiragkyal @pmtk

@dhellmann

Copy link
Copy Markdown
Contributor Author

/assign @copejon

I see some CSI permission changes here, can you take a look, please?

@openshift-ci
openshift-ci Bot requested review from jerpeter1 and pmtk July 6, 2023 15:03
@openshift-ci

openshift-ci Bot commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2023
@copejon

copejon commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

/assign @copejon

I see some CSI permission changes here, can you take a look, please?

👀

@copejon

copejon commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

Ah, we shouldn't be preserving the 05_operand_rbac.yaml for one. The automation should have rm'd that immediately after extracting the yaml docs from it.

The Roles that are added were also not supposed to be included, since they're only for leaderpermissions, which isn't active. I'll re-check the script to see what's going on.

Specifically, this role/binding:
assets/components/csi-snapshot-controller/role.yaml
assets/components/csi-snapshot-controller/rolebinding.yaml

@dhellmann

Copy link
Copy Markdown
Contributor Author

/close

I see errors in the diff file, so I suspect this is not a good change.

@openshift-ci openshift-ci Bot closed this Jul 6, 2023
@openshift-ci

openshift-ci Bot commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

@dhellmann: Closed this PR.

Details

In response to this:

/close

I see errors in the diff file, so I suspect this is not a good change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci

openshift-ci Bot commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

@dhellmann: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify b08a93e link true /test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dhellmann

Copy link
Copy Markdown
Contributor Author

/reopen

@openshift-ci

openshift-ci Bot commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

@dhellmann: Failed to re-open PR: state cannot be changed. The rebase-4.14.0-0.nightly-2023-07-05-191022_amd64-2023-07-05_arm64-2023-07-05 branch was force-pushed or recreated.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants